Subtitle demux issue

User avatar
Rocky
Moose Approved
Posts: 2503
Joined: Fri Sep 06, 2019 12:57 pm

Subtitle demux issue

Post by Rocky »

OK, the fix for Peter was a regression. When I back it out your disk works fine. I have to re-rip his disk and re-investigate his issue.
DAE avatar
downloaded
Posts: 4
Joined: Sat Nov 19, 2022 11:51 am

Subtitle demux issue

Post by downloaded »

Sorry for the late reply and thank you for your time looking into this. It's very appreciated!
User avatar
Rocky
Moose Approved
Posts: 2503
Joined: Fri Sep 06, 2019 12:57 pm

Subtitle demux issue

Post by Rocky »

Thanks for reply. I will try to fix this on Friday (tomorrow). I'm away for the holiday today.
User avatar
Rocky
Moose Approved
Posts: 2503
Joined: Fri Sep 06, 2019 12:57 pm

Subtitle demux issue

Post by Rocky »

Decided to slipstream a temporary fix into 63, so re-download and test please. I'll come back to Peter's issue tomorrow. It seems like a rare corner case.
DAE avatar
downloaded
Posts: 4
Joined: Sat Nov 19, 2022 11:51 am

Subtitle demux issue

Post by downloaded »

Thank you for taking time to work on it.

I will test and let you know the result.
User avatar
Rocky
Moose Approved
Posts: 2503
Joined: Fri Sep 06, 2019 12:57 pm

Subtitle demux issue

Post by Rocky »

With the corrected version, i.e., the version 63 currently online, I am unable to reproduce Peter's original problem. So unless he posts again about it, I'll consider this resolved.
DAE avatar
Peter
Moose Approved
Posts: 10
Joined: Thu Aug 18, 2022 9:34 am

Subtitle demux issue

Post by Peter »

Apologies for the delay. Using DGDemux v1.0.0.63, I still get the same behavior. In the demuxed subtitles, caption 1397 (the last caption, which was from the last m2ts file, 00010.m2ts) has the start/end times of 00:00:01.043/00:00:01.960.

Opening the file in BDSup2Sub/BDSup2Sub++ yields the following:
WARNING: end time of frame 1396 > start time of next frame
User avatar
Rocky
Moose Approved
Posts: 2503
Joined: Fri Sep 06, 2019 12:57 pm

Subtitle demux issue

Post by Rocky »

Did you re-download DGDemux 63 to be sure you have the latest version?
DAE avatar
Peter
Moose Approved
Posts: 10
Joined: Thu Aug 18, 2022 9:34 am

Subtitle demux issue

Post by Peter »

Rocky wrote:
Mon Dec 05, 2022 9:22 am
Did you re-download DGDemux 63 to be sure you have the latest version?
Binary date is 11/29. Is that not the latest?
User avatar
Rocky
Moose Approved
Posts: 2503
Joined: Fri Sep 06, 2019 12:57 pm

Subtitle demux issue

Post by Rocky »

That is the correct one. I'll try again to duplicate this.
User avatar
Rocky
Moose Approved
Posts: 2503
Joined: Fri Sep 06, 2019 12:57 pm

Subtitle demux issue

Post by Rocky »

Duplicated and fixed locally. Have to re-test All Creatures with -sf and any other disk without -sf. Then I'll give you a test version.
User avatar
Rocky
Moose Approved
Posts: 2503
Joined: Fri Sep 06, 2019 12:57 pm

Subtitle demux issue

Post by Rocky »

@Peter and downloaded:

OK guys, I think I have fixed it correctly this time. Let's see. Please re-download build 63 and update DGDemux.exe. If you find it working correctly please let me know and I'll fix it for DGIndexNV also.
DAE avatar
Peter
Moose Approved
Posts: 10
Joined: Thu Aug 18, 2022 9:34 am

Subtitle demux issue

Post by Peter »

It looks to be correct now, for the issue I reported. Thanks!
User avatar
Rocky
Moose Approved
Posts: 2503
Joined: Fri Sep 06, 2019 12:57 pm

Subtitle demux issue

Post by Rocky »

Great to hear, thank you. I tested All Creatures successfully too so it looks like this version is a keeper.
Post Reply