[LOCKED] EAC3TO Bug Reports and Feature Requests Only

eac3to forked from madshi eac3to 3.36
Locked
DAE avatar
DelBoy83
Posts: 48
Joined: Wed Oct 04, 2023 2:04 am

EAC3TO Bug Reports and Feature Requests Only

Post by DelBoy83 »

eac3to has come a long way since I last commented, well done to everyone involved on greatly improving eac3to. I've just been reading through the forum and noticed you plan to change the chapters? I'm with trunks/trojiteEL in keeping them as they are at the moment. From what I read on the doom9 forum eac3to left out any chapters which were 10 seconds from the end which I personally agree with. Thanks again Curly and the DG team.
User avatar
Curly
Posts: 716
Joined: Sun Mar 15, 2020 11:05 am

EAC3TO Bug Reports and Feature Requests Only

Post by Curly »

Thank you and you're welcome.

"I personally agree with"

What would impersonal agreement look like? :lol:

1. Did you read our justification and what is your response to it?
2. Why is it a problem for you? If you're going to say "because I have to remove it manually" then tell me why you have to remove it.

Nobody has answered those yet.
Curly Howard
Director of EAC3TO Development
User avatar
skull
Posts: 69
Joined: Thu Nov 02, 2023 7:58 pm
Location: canada

EAC3TO Bug Reports and Feature Requests Only

Post by skull »

I'm afraid I'm siding with Curly and Rocky on this one. If it's in the retail file that way, then it's not really our place to decide we don't like that last chapter marker and delete it. If you don't like it, it is incredibly easy to remove, you can even do it all the way at the end of your workflow using chapteredit or mkvtoolnix without having to remux. No need to re-start the same debate again, but that's my take.
DAE avatar
DelBoy83
Posts: 48
Joined: Wed Oct 04, 2023 2:04 am

EAC3TO Bug Reports and Feature Requests Only

Post by DelBoy83 »

Curly wrote:
Fri Dec 08, 2023 12:14 pm
Thank you and you're welcome.

"I personally agree with"

What would impersonal agreement look like? :lol:

1. Did you read our justification and what is your response to it?
2. Why is it a problem for you? If you're going to say "because I have to remove it manually" then tell me why you have to remove it.

Nobody has answered those yet.
I have read your justification and I'm just saying that I would prefer for the chapters to stay as they are. I brought the same question up a few months ago on the dgdemux forum page too. Using dgdemux I used to demux the chapters with eac3to and then add the demuxed files from dgdemux. I could also do what the other poster did and delete chapter marker too but I just used the eac3to route. Why would I want a chapter marker that goes directly to the end of the film? Using eac3to as it stands now the last chapter marker is credits which is understandable imo.
User avatar
Curly
Posts: 716
Joined: Sun Mar 15, 2020 11:05 am

EAC3TO Bug Reports and Feature Requests Only

Post by Curly »

ur answer to 1: I would prefer.
ur answer to 2: Why would I want?

u gotta tell us why it is a problem
Curly Howard
Director of EAC3TO Development
DAE avatar
DelBoy83
Posts: 48
Joined: Wed Oct 04, 2023 2:04 am

EAC3TO Bug Reports and Feature Requests Only

Post by DelBoy83 »

Thankyou for getting back to me so quickly Curly, I am getting a bit emotional yes. I simply would like for the chapters to be kept as they are, just the same as eac3to 3.36 and makemkv. If you want to change then that's entirely your choice but I wanted to let you know that I side with the other two posters in terms of keeping them as they are.
User avatar
Natasha
Posts: 150
Joined: Wed Nov 20, 2019 11:11 am

EAC3TO Bug Reports and Feature Requests Only

Post by Natasha »

Why do you want to do this?
Because I want to.
Pretty clear to me.
User avatar
new_guy
Posts: 59
Joined: Fri Jan 15, 2021 11:12 am

EAC3TO Bug Reports and Feature Requests Only

Post by new_guy »

Me too.
User avatar
SomeHumanPerson
Posts: 96
Joined: Fri Mar 24, 2023 10:41 am

EAC3TO Bug Reports and Feature Requests Only

Post by SomeHumanPerson »

I don't have a horse in the chapters race, but to play devil's advocate for a moment... what use would someone have for a chapter marker less than 10 seconds from EoF? Please describe a situation in which that feature is specifically useful.

:popcorn:
User avatar
Rocky
Posts: 3621
Joined: Fri Sep 06, 2019 12:57 pm

EAC3TO Bug Reports and Feature Requests Only

Post by Rocky »

The bluray spec says an end chapter may or may not be present and it is potentially used in BD-J. MakeMKV retains it if it is present. MPC-HC shows it on the timeline. If one wants to precisely re-author a disk it should be retained. EAC3TO appears to be the only app that throws away the end chapter.

It is at least harmless and may be used in some BD-J operations. We will retain it unless someone shows how it is harmful or needlessly complicates a workflow. Don't just say I don't want it!

@hubblec4

Do you have any input for us on this issue based on your cE experience?
User avatar
hubblec4
Posts: 221
Joined: Tue May 02, 2023 6:03 pm

EAC3TO Bug Reports and Feature Requests Only

Post by hubblec4 »

Hi Rocky and all others

Yes indeed I can provide a little info (knowledge and experience).

The "Last Chapter" is a technical way which comes from DVD. The last chapter is used to make some internal action automatically, jump back to main menu or something else.

Like Rocky says it is used on Blu-ray to do the same like DVDs does. I have not much experience with BD-J, but I guess there are also some actions which will handled with java code.

Some players can not handle a last chapter correctly if it is very close to the end of the file.
A jump to this chapter is mostly not possible, I can only guess here: to few data, to short to show a video frame...

That is maybe the reason why many tools remove the last chapter by default, some tools offers an option to keep the last chapter, and cE offers an option to keep a last chapter by a given playtime.

The playtime of such a last chapter is mostly 0,5 seconds on DVDs, on Blu-rays I found a wider range from 0.2 seconds up to 2,02 seconds. And some Blu-rays have a last chapter with 4 or 5 seconds and this is a full used chapter and should never removed.

eac3to_mod: Curly can maybe add an option to keep the last chapter with the option of the playtime of the chapter.
10 seconds are to much for automatic removing the last chapter.


Matroska offers also a chapter process command handling and mpvMatroska is now also able to handle the Matroska Native Menu command GotoAndPlay();.
This can be used with a last chapter to jump back to the beginning of the file, or jump to a menu edition ...and so on.
User avatar
Curly
Posts: 716
Joined: Sun Mar 15, 2020 11:05 am

EAC3TO Bug Reports and Feature Requests Only

Post by Curly »

Thank you hubblec4! I will consider the option but for the moment the last chapter is retained in all cases. Would love to see an instance of this causing a problem.

Here is a test build for 3.42:

* Last chapter is maintained.
* The notes document has been updated.
* The -showall option is removed and replaced with -minDuration. To set a minimum of 10 minutes,
you would use -minDuration=600. To show all playlists you would use -minDuration=0. This can be set
either in the INI file or on the command line. E.g.,

eac3to g:\rips\a_quiet_place -minDuration=3000

Now Bandits won't hate me. ;) Your testing will be appreciated. Thank you.

https://rationalqm.us/eac3to
Curly Howard
Director of EAC3TO Development
User avatar
hubblec4
Posts: 221
Joined: Tue May 02, 2023 6:03 pm

EAC3TO Bug Reports and Feature Requests Only

Post by hubblec4 »

Curly wrote:
Sat Dec 09, 2023 11:26 am
Would love to see an instance of this causing a problem.
You can create easy a test sample. Take a video file (mkv) and set a chapter close to the end of the file
and play it with different players. Maybe nowadays all players able to handle the last chapter correctly.

Curly wrote:
Sat Dec 09, 2023 11:26 am
Here is a test build for 3.42:

* Last chapter is maintained.
This is not a good solution, because the last chapter is not really used by Blu-ray players and not shown to the user.

There are many Blu-rays with this constellation: For example, in the Chapter menu of the Blu-ray, a user can see 16 chapters, but the mpls provides 17 chapters.

This is the normal case and the last chapter must be ignored.
User avatar
Curly
Posts: 716
Joined: Sun Mar 15, 2020 11:05 am

EAC3TO Bug Reports and Feature Requests Only

Post by Curly »

I don't want to grope around trying to create a failure. If you know of one, please give me what I need to see it. The stream or disk, the player, and the result that is problematic. Thank you.

Are you aware that DGDemux always keeps the last chapter? Why haven't you or anyone else complained about that?
Curly Howard
Director of EAC3TO Development
User avatar
Baltasar
Posts: 60
Joined: Tue Nov 02, 2021 9:51 am

EAC3TO Bug Reports and Feature Requests Only

Post by Baltasar »

Don't hold your breath. We've asked repeatedly to be shown the problem. Let it go.

Are you going to make a UTF8 manifest for eac3to, etc.?
User avatar
Curly
Posts: 716
Joined: Sun Mar 15, 2020 11:05 am

EAC3TO Bug Reports and Feature Requests Only

Post by Curly »

yeah sir but different
Curly Howard
Director of EAC3TO Development
User avatar
Albert
Posts: 40
Joined: Thu Oct 15, 2020 1:20 pm

EAC3TO Bug Reports and Feature Requests Only

Post by Albert »

Weed out the wide character nonsense.
User avatar
Curly
Posts: 716
Joined: Sun Mar 15, 2020 11:05 am

EAC3TO Bug Reports and Feature Requests Only

Post by Curly »

natchally knerk
Curly Howard
Director of EAC3TO Development
User avatar
hubblec4
Posts: 221
Joined: Tue May 02, 2023 6:03 pm

EAC3TO Bug Reports and Feature Requests Only

Post by hubblec4 »

Curly wrote:
Sat Dec 09, 2023 12:18 pm
I don't want to grope around trying to create a failure. If you know of one, please give me what I need to see it. The stream or disk, the player, and the result that is problematic. Thank you.
Yes OK, I will keep it in my mind. I have some new Blu-rays and will check if there is an issue with the last chapter.
Curly wrote:
Sat Dec 09, 2023 12:18 pm
Are you aware that DGDemux always keeps the last chapter? Why haven't you or anyone else complained about that?
Yes I know, and I have also never used the chapters from eac3to. cE has its own chapter parsers for many formats.

"complained about " ...mmh, I don't know. (Maybe I'm the only one who puts so much emphasis on the chapters.)

In general it would be good not to change the original functions of eac3to. A new switch --keeplastchapter would be better IMO.
or better with the duration of the last chapter.

But in the end the other users should decided this, how important this is.
User avatar
Curly
Posts: 716
Joined: Sun Mar 15, 2020 11:05 am

EAC3TO Bug Reports and Feature Requests Only

Post by Curly »

hubblec4 wrote:
Sat Dec 09, 2023 1:13 pm
In general it would be good not to change the original functions of eac3to.
Use 3.36 forever if you want that. You can't show a problem, nobody else can, but you make these demands.
Curly Howard
Director of EAC3TO Development
User avatar
Wonder Woman
Posts: 58
Joined: Sun Feb 07, 2021 10:46 am

EAC3TO Bug Reports and Feature Requests Only

Post by Wonder Woman »

RCMP DoRight and myself are hereby offering a $$$ REWARD $$$ for the demonstration of mayhem or other problematic consequences, from the retention of the final chapter, when the position of said chapter is within some time epsilon of the end of the movie.

Background: In early DVD times it is said that some primitive players glitched upon receipt of this perfectly legal construct, and that therefore forever more we must discard the final chapter satisfying the temporal definition above, disregarding the fact that such chapters are fully legal bluray constructs.

Claiming: Present evidence of mayhem to Director Curly Howard via an online posting.

Reward: Fame and fortune beyond your dreams.
User avatar
SomeHumanPerson
Posts: 96
Joined: Fri Mar 24, 2023 10:41 am

EAC3TO Bug Reports and Feature Requests Only

Post by SomeHumanPerson »

Rocky wrote:
Sat Dec 09, 2023 4:44 am
The bluray spec says an end chapter may or may not be present and it is potentially used in BD-J ... If one wants to precisely re-author a disk it should be retained ... It is at least harmless and may be used in some BD-J operations.
hubblec4 wrote:
Sat Dec 09, 2023 10:36 am
The "Last Chapter" is a technical way which comes from DVD. The last chapter is used to make some internal action automatically, jump back to main menu or something else.
These points alone are enough to sell me on the "keep it" argument.
User avatar
skull
Posts: 69
Joined: Thu Nov 02, 2023 7:58 pm
Location: canada

EAC3TO Bug Reports and Feature Requests Only

Post by skull »

Totally agree. I can't believe people are making so much of this, lol. Removing the last chapter is one of the most trivial, simple operations you'll ever have to perform in your workflow for disc backups, if your heart desires. Let it go, and as others have pointed out, you're free to use older versions or alternative software. Keep up the great work Curly.

For v3.42, what is the default if -minDuration is not set at all, is it 0 or 600? Just curious.

By the way, Curly, in case you missed it with all this chapter debate, Trunks had an earlier bug reported about changing framerate: https://www.rationalqm.us/board/viewtop ... 919#p18919
User avatar
Curly
Posts: 716
Joined: Sun Mar 15, 2020 11:05 am

EAC3TO Bug Reports and Feature Requests Only

Post by Curly »

The default is 10 minutes. Thought I had that in the notes file but maybe not. I'll check it.

Yeah I missed the Trunks post. I'll look at it today.
Curly Howard
Director of EAC3TO Development
DAE avatar
horseshowers
Posts: 20
Joined: Sun Jul 16, 2023 4:09 am

EAC3TO Bug Reports and Feature Requests Only

Post by horseshowers »

Great to see eac3to still being worked on.

I've found an issue: the program encodes an AC3 file when demuxing Shrek 3D, even if I just run the -check command. I can provide the files through PM if needed.

Code: Select all

eac3to v3.41
command line: eac3to  "D:\Temp\Shrek 2001 1080p 3D Blu-ray AVC TrueHD 7.1 -Audi8914" -check
------------------------------------------------------------------------------
Running in normal mode
Removing dialnorm
M2TS, 2 video tracks, 11 audio tracks, 4 subtitle tracks, 1:30:05, 24p /1.001
1: Chapters, 20 chapters
2: h264/AVC  (left eye), 1080p24 /1.001 (16:9)
3: h264/MVC (right eye), 1080p24 /1.001 (16:9)
4: AC3, German, 5.1 channels, 640kbps, 48kHz, dialnorm: -27dB
5: TrueHD/AC3, English, 7.1 channels, 48kHz, dialnorm: -31dB
   (embedded: AC3, 5.1 channels, 640kbps, 48kHz, dialnorm: -31dB)
6: AC3, Spanish, 5.1 channels, 640kbps, 48kHz, dialnorm: -27dB
7: AC3, French, 5.1 channels, 640kbps, 48kHz, dialnorm: -27dB
8: AC3, Italian, 5.1 channels, 640kbps, 48kHz, dialnorm: -27dB
9: AC3, Korean, 5.1 channels, 640kbps, 48kHz, dialnorm: -27dB
10: AC3, Chinese, 5.1 channels, 640kbps, 48kHz, dialnorm: -27dB
11: AC3, Dutch, 5.1 channels, 640kbps, 48kHz, dialnorm: -27dB
12: AC3, Portuguese, 5.1 channels, 640kbps, 48kHz, dialnorm: -27dB
13: AC3, Russian, 5.1 channels, 640kbps, 48kHz, dialnorm: -27dB
14: AC3, Turkish, 5.1 channels, 640kbps, 48kHz, dialnorm: -27dB
15: Subtitle (PGS), Korean
16: Subtitle (PGS), Chinese
17: Subtitle (PGS), Russian
18: Subtitle (PGS), Turkish
[a05] AC3 encoding doesn't support back channels. Will mix them into the surround.
[v02] Extracting video track number 2...
[a08] Extracting audio track number 8...
[a09] Extracting audio track number 9...
[a10] Extracting audio track number 10...
[a06] Extracting audio track number 6...
[a05] Extracting audio track number 5...
[a11] Extracting audio track number 11...
[a07] Extracting audio track number 7...
[s16] Extracting subtitle track number 16...
[a14] Extracting audio track number 14...
[s17] Extracting subtitle track number 17...
[a04] Extracting audio track number 4...
[a05] Extracting audio track number 5...
[s15] Extracting subtitle track number 15...
[s18] Extracting subtitle track number 18...
[a13] Extracting audio track number 13...
[a12] Extracting audio track number 12...
[a05] Extracting TrueHD stream...
[a05] Extracting TrueHD stream...
[a05] Decoding with libav/ffmpeg...
[a05] Mixing surround channels...
[a05] Remapping channels...
[a05] Encoding AC3 <640kbps> with libAften...
[a05] The original audio track has a constant bit depth of 20 bits.
[a05] Processed audio track, L+R+C+LFE: constant bit depth of 20 bits.
[a05] Processed audio track, SL+SR: max 24 bits, average 21 bits.
Video track 2 contains 129600 frames.
Video track 3 contains 129600 frames.
Subtitle track 15 contains 1 caption.
Subtitle track 16 contains 1 caption.
Subtitle track 17 contains 1 caption.
Subtitle track 18 contains 1 caption.
eac3to processing took 5 minutes, 5 seconds.
Done.
The command doesn't say eac3to_mod because I renamed the exe.

Also, a very nice fix would be to replace the error/success wav files. I have done so locally with WinXP sounds, but occasionally forget to do so when updating. Always a shock how LOUD the default sounds are.
Locked