[LOCKED] EAC3TO Bug Reports and Feature Requests Only
EAC3TO Bug Reports and Feature Requests Only
Windows Defender doesn't seem to like v3.42, it says "Win32/Wacapew.C!ml": https://www.virustotal.com/gui/file/29d ... bf65ce009d
3.41 is okay: https://www.virustotal.com/gui/file/083 ... 7ebfa11db6
3.41 is okay: https://www.virustotal.com/gui/file/083 ... 7ebfa11db6
EAC3TO Bug Reports and Feature Requests Only
I'll drop everything to figure this out...NOT!
Curly Howard
Director of EAC3TO Development
Director of EAC3TO Development
EAC3TO Bug Reports and Feature Requests Only
Ooh ooh ooh, I may have stumbled onto a way to accept 264/265 streams without AUDs. I just disabled all the checks for no AUDs and called SetFormat in the SPS processing code, and voila it seems to work fine for stuff like:
eac3to "G:\Streams\HEVC\HD\8 Bit\Alba.hevc" out.hevc -24.000 -changeTo23.976
eac3to file1.hevc+file2.hevc out.hevc
I think it works because looking at the AUD processing code, I see only very complex code all just setting up variables that are used in the phase 2 gaps correction. Recall that there is a basic level of gaps correction and a second level intended to do fine tuning or whatever (it's too hard to understand without comments). Anyway, we already disabled phase 2 previously because it was destroying all sync. It's unlikely that phase 2 will ever be re-enabled because the code is totally opaque, doesn't work, and is unnecessary. I think it was intended to be the secret sauce that would set eac3to apart as the premiere gaps corrector. Would have been nice if it worked. Possibly it is the reason for development stopping at 3.36.
I've got to double check that the AUD code isn't doing something else important but this may be a fix for the AUD problem.
In case you are wondering, DGDemux does not parse any streams, it gets stream parameters from the CLPIs. That's fine because DGDemux can open only disks, so CLPIs are guaranteed to be present. eac3to needs to parse the SPS to get the video details for non-disk streams. That too is fine. The AUDs were used only to support phase 2 gaps processing it appears.
I'll probably make a test build with this for y'all to test. I'll do some thorough testing as well.
eac3to "G:\Streams\HEVC\HD\8 Bit\Alba.hevc" out.hevc -24.000 -changeTo23.976
eac3to file1.hevc+file2.hevc out.hevc
I think it works because looking at the AUD processing code, I see only very complex code all just setting up variables that are used in the phase 2 gaps correction. Recall that there is a basic level of gaps correction and a second level intended to do fine tuning or whatever (it's too hard to understand without comments). Anyway, we already disabled phase 2 previously because it was destroying all sync. It's unlikely that phase 2 will ever be re-enabled because the code is totally opaque, doesn't work, and is unnecessary. I think it was intended to be the secret sauce that would set eac3to apart as the premiere gaps corrector. Would have been nice if it worked. Possibly it is the reason for development stopping at 3.36.
I've got to double check that the AUD code isn't doing something else important but this may be a fix for the AUD problem.
In case you are wondering, DGDemux does not parse any streams, it gets stream parameters from the CLPIs. That's fine because DGDemux can open only disks, so CLPIs are guaranteed to be present. eac3to needs to parse the SPS to get the video details for non-disk streams. That too is fine. The AUDs were used only to support phase 2 gaps processing it appears.
I'll probably make a test build with this for y'all to test. I'll do some thorough testing as well.
Curly Howard
Director of EAC3TO Development
Director of EAC3TO Development
EAC3TO Bug Reports and Feature Requests Only
Found another cause of HEVC stream failure. The code to parse the short term ref pic set is wrong. Rocky has working code in DGIndexNV so it should be easy to fix.
Curly Howard
Director of EAC3TO Development
Director of EAC3TO Development
EAC3TO Bug Reports and Feature Requests Only
Hello, eac3to currently does not provide you the amount of delay that was not able to be fixed when using the -edit command, as opposed to its behaviour when using just a simple delay. Showing the unfixed delay when using -edit could really help out in some specific cases and also makes the behaviour more consistent. Can you look into it, please? Also, thank you very much for your recent efforts in making eac3to better!
EAC3TO Bug Reports and Feature Requests Only
Thank you kz and welcome to the forum! I have added your request to the to-do list.
Curly Howard
Director of EAC3TO Development
Director of EAC3TO Development
EAC3TO Bug Reports and Feature Requests Only
Guys, here is a test build for 3.43:
* Accept streams without AUDs for HEVC streams.
* Fix parsing of HEVC SPS.
I'll have to do the same for AVC next. I put this in the misc folder so hopefully no-one
will try to release it.
https://rationalqm.us/misc/eac3to_3.43_test.rar
* Accept streams without AUDs for HEVC streams.
* Fix parsing of HEVC SPS.
I'll have to do the same for AVC next. I put this in the misc folder so hopefully no-one
will try to release it.
https://rationalqm.us/misc/eac3to_3.43_test.rar
Curly Howard
Director of EAC3TO Development
Director of EAC3TO Development
- kedautinh12
- Posts: 3
- Joined: Mon May 30, 2022 6:28 am
EAC3TO Bug Reports and Feature Requests Only
Link died, can you provide other link??Curly wrote: ↑Thu Dec 14, 2023 2:26 pmGuys, here is a test build for 3.43:
* Accept streams without AUDs for HEVC streams.
* Fix parsing of HEVC SPS.
I'll have to do the same for AVC next. I put this in the misc folder so hopefully no-one
will try to release it.
https://rationalqm.us/misc/eac3to_test_3.43.rar
Ok, i got it
https://www.rationalqm.us/misc/eac3to_3.43_test.rar
EAC3TO Bug Reports and Feature Requests Only
I corrected the link. Thank you for pointing it out.
Curly Howard
Director of EAC3TO Development
Director of EAC3TO Development
EAC3TO Bug Reports and Feature Requests Only
gonna get slammed for this
i removed the warnings for "unusual" frame rates
like 24 and 30 are unusual?!
@Guest 3
figgered u'd like that
pls lemme no if there are any issues with UsEac3to
saw someone had a problem with 3.43 test
if he hits send bug report it will come to us not madshi
help me out...why would he drop eac3to.exe onto UsEac3to?
thanku
@oniiz86
u can discuss it here if u want
i removed the warnings for "unusual" frame rates
like 24 and 30 are unusual?!
@Guest 3
figgered u'd like that
pls lemme no if there are any issues with UsEac3to
saw someone had a problem with 3.43 test
if he hits send bug report it will come to us not madshi
help me out...why would he drop eac3to.exe onto UsEac3to?
thanku
@oniiz86
u can discuss it here if u want
Curly Howard
Director of EAC3TO Development
Director of EAC3TO Development
EAC3TO Bug Reports and Feature Requests Only
I think that warning should still be kept for actual "unusual" framerates, but agreed it shouldn't warn about 24fps or 30fps or any other normal values used in video production historically.
EAC3TO Bug Reports and Feature Requests Only
The warning was only for 24 and 30!
But I don't see the point of ever warning about unusual anything framerate. Show me why.
But I don't see the point of ever warning about unusual anything framerate. Show me why.
Curly Howard
Director of EAC3TO Development
Director of EAC3TO Development
EAC3TO Bug Reports and Feature Requests Only
OK, thanks to oniiz86 I now see that eac3to 3.42 and 3.43 test crashes without an INI file. I'll fix that right now and update the test build. For now, just make an empty INI file if you don't want any commands in there.
Curly Howard
Director of EAC3TO Development
Director of EAC3TO Development
EAC3TO Bug Reports and Feature Requests Only
I would have thought an actual strange framerate could indicate a corrupt file or file header so could be nice heads-up for user, but maybe not necessary or job of eac3to. I didn't realize original code only triggered on 24/30p, lol.
EAC3TO Bug Reports and Feature Requests Only
Build 3.43 test updated with the fix for no INI file.
@skull
Thanks for clarification. There are lots of weird values associated with silent films, time-lapse stuff, etc. Seems problematic to define weird in any way that could be helpful. Also, I agree that this is not eac3to's job.
@skull
Thanks for clarification. There are lots of weird values associated with silent films, time-lapse stuff, etc. Seems problematic to define weird in any way that could be helpful. Also, I agree that this is not eac3to's job.
Curly Howard
Director of EAC3TO Development
Director of EAC3TO Development
EAC3TO Bug Reports and Feature Requests Only
Thanks for that @curly can confirm 3.43 test now indeed works fine without the INI present, sorry to ask but I'm assuming the 3.42 build is still affected here https://www.rationalqm.us/eac3to/
Not sure why I'm getting a crash with UsEac3to 1.3.3 with the latest 3.43 test build but not with 3.41 or 3.42 (INI file present) with a particular MKV file,
The MKV file isn't anything fancy, it has a DTS-HD HR 5.1 track,
Not sure why I'm getting a crash with UsEac3to 1.3.3 with the latest 3.43 test build but not with 3.41 or 3.42 (INI file present) with a particular MKV file,
The MKV file isn't anything fancy, it has a DTS-HD HR 5.1 track,
General
Unique ID : 253597471339195804519401910651191645588 (0xBEC918ACD69EDD7712F32C09C0F55594)
Complete name : P:\Hitman 2007 Unrated.mkv
Format : Matroska
Format version : Version 4
File size : 12.5 GiB
Duration : 1 h 34 min
Overall bit rate mode : Variable
Overall bit rate : 19.0 Mb/s
Frame rate : 23.976 FPS
Movie name : Hitman 2007 Unrated
Encoded date : 2023-08-26 06:40:54 UTC
Writing application : mkvmerge v79.0.10 ('Funeral Pyres - Non official') 64-bit
Writing library : libebml v1.4.4 + libmatroska v1.7.1
Video
ID : 1
Format : AVC
Format/Info : Advanced Video Codec
Format profile : High@L4.1
Format settings : CABAC / 2 Ref Frames
Format settings, CABAC : Yes
Format settings, Reference : 2 frames
Codec ID : V_MPEG4/ISO/AVC
Duration : 1 h 34 min
Bit rate mode : Variable
Bit rate : 16.0 Mb/s
Width : 1 920 pixels
Height : 1 080 pixels
Display aspect ratio : 16:9
Frame rate mode : Constant
Frame rate : 23.976 (24000/1001) FPS
Color space : YUV
Chroma subsampling : 4:2:0
Bit depth : 8 bits
Scan type : Progressive
Bits/(Pixel*Frame) : 0.321
Time code of first frame : 00:59:59:00
Stream size : 10.5 GiB (84%)
Default : Yes
Forced : No
Audio
ID : 2
Format : DTS XBR
Format/Info : Digital Theater Systems
Commercial name : DTS-HD High Resolution Audio
Codec ID : A_DTS
Duration : 1 h 34 min
Bit rate mode : Constant
Bit rate : 3 018 kb/s
Channel(s) : 6 channels
Channel layout : C L R Ls Rs LFE
Sampling rate : 48.0 kHz
Frame rate : 93.750 FPS (512 SPF)
Bit depth : 24 bits
Compression mode : Lossy
Stream size : 1.99 GiB (16%)
Title : DTS-HD HR 5.1
Language : English
Default : Yes
Forced : No
EAC3TO Bug Reports and Feature Requests Only
yes 3.42 is not fixed maybe i'll update it maybe not
i don't have a 3.42 build right now and you can just make an empty ini file
or make one with the default settings
i don't have a 3.42 build right now and you can just make an empty ini file
or make one with the default settings
Curly Howard
Director of EAC3TO Development
Director of EAC3TO Development
EAC3TO Bug Reports and Feature Requests Only
I also use UsEac3to and have not had any crashes with latest v3.43 test (see update below, as now I have re-produced crash), I used .mkv files, discs and .m2ts as inputs with no issues, thus far. Can you provide a short sample file? Make sure you don't have any 64-bit or unexpected .dll files in the directory. I had crashes when I tried to use newer/64-bit .dll's in the past, but works fine if you use the ones that come in the eac3to archive.
UPDATE: I was just able to hit the crash that may be the same as oniiz86 experienced but it happens with or without UsEac3to involved and only with v3.43 test, so it might have something to do with certain .MKV files that have AVC/DTS-HD combination, it doesn't happen if I remove the audio track and remux into .mkv with only video track, and doesn't happen when video track is HEVC. I confirmed subtitles/chapters tracks didn't have a role in the crash. Curly, sample here to re-produce/debug: https://we.tl/t-cq3UH6fj3G
Truncated bugreport log:
Code: Select all
operating system : Windows 10 x64 build 19045
system language : English
system up time : 1 day 4 hours
program up time : 179 milliseconds
processors : 6x Intel(R) Core(TM) i5-9600K CPU @ 3.70GHz
physical memory : 23479/32689 MB (free/total)
free disk space : (C:) 140.95 GB (S:) 2292.14 GB
display mode : 2560x1440, 32 bit
process id : $23b4
allocated memory : 81.22 MB
largest free block : 1.35 GB
command line : "S:\EAC3TO\eac3to.exe" "D:\test-001.mkv" -progressnumbers -log="S:\EAC3TO\UsEac3To.log"
executable : eac3to.exe
exec. date/time : 2023-12-15 10:19
version : 3.43.0.0
compiled with : Delphi 7
madExcept version : 4.0.21
callstack crc : $90fabbd8, $59720fa1, $eaf37087
exception number : 1
exception class : EAccessViolation
exception message : Access violation at address 00402760 in module 'eac3to.exe'. Read of address 47F13130.
main thread ($1810):
00402760 +134 eac3to.exe System SysFreeMem
00402b09 +005 eac3to.exe System @FreeMem
004943aa +0f6 eac3to.exe madUpStream 905 +15 TUpStream.Destroy
00407175 +01d eac3to.exe System TInterfacedObject._Release
00407080 +010 eac3to.exe System @IntfClear
00405ebf +0bf eac3to.exe System @FinalizeArray
0040693b +02b eac3to.exe System @DynArrayClear
00405ed0 +0d0 eac3to.exe System @FinalizeArray
00405dd4 +020 eac3to.exe System @FinalizeRecord
004040ca +012 eac3to.exe System TObject.CleanupInstance
0040400d +005 eac3to.exe System TObject.FreeInstance
0046100d +019 eac3to.exe madExcept InterceptClassDestroy
004943f4 +140 eac3to.exe madUpStream 907 +17 TUpStream.Destroy
00407175 +01d eac3to.exe System TInterfacedObject._Release
00407080 +010 eac3to.exe System @IntfClear
00405ebf +0bf eac3to.exe System @FinalizeArray
00405dd4 +020 eac3to.exe System @FinalizeRecord
00405eaf +0af eac3to.exe System @FinalizeArray
0040693b +02b eac3to.exe System @DynArrayClear
00405ed0 +0d0 eac3to.exe System @FinalizeArray
00405dd4 +020 eac3to.exe System @FinalizeRecord
004040ca +012 eac3to.exe System TObject.CleanupInstance
0040400d +005 eac3to.exe System TObject.FreeInstance
0046100d +019 eac3to.exe madExcept InterceptClassDestroy
004943f4 +140 eac3to.exe madUpStream 907 +17 TUpStream.Destroy
00407175 +01d eac3to.exe System TInterfacedObject._Release
00407080 +010 eac3to.exe System @IntfClear
00405ebf +0bf eac3to.exe System @FinalizeArray
0040693b +02b eac3to.exe System @DynArrayClear
00405ed0 +0d0 eac3to.exe System @FinalizeArray
00405dd4 +020 eac3to.exe System @FinalizeRecord
004040ca +012 eac3to.exe System TObject.CleanupInstance
0040400d +005 eac3to.exe System TObject.FreeInstance
0046100d +019 eac3to.exe madExcept InterceptClassDestroy
004a745e +082 eac3to.exe madFileStream 1208 +11 TSourceFiles.Destroy
00407175 +01d eac3to.exe System TInterfacedObject._Release
00407080 +010 eac3to.exe System @IntfClear
0057ffb7 +7a7 eac3to.exe eac3to 3103 +70 QuickFindSourceAudioFormat
00593933 +46b eac3to.exe eac3to 5887 +83 DoItAll
005a1e56 +02e eac3to.exe eac3to 7586 +16 initialization
76eefcc7 +017 KERNEL32.DLL BaseThreadInitThunk
main thread ($1810), inner exception level 1:
>> EAccessViolation, Access violation at address 00499AF6 in module 'eac3to.exe'. Write of address 061F8000
00499af6 +00be eac3to.exe madBits 262 +32 PutBits
00499be6 +0016 eac3to.exe madBits 315 +2 CopyBits
00499cd5 +0069 eac3to.exe madBits 366 +21 CopyAllRemainingBits
00535e85 +1d9d eac3to.exe madVideo 3480 +487 Th265Reader.Process
005687d8 +0080 eac3to.exe madFormatDetector 180 +6 TFormatDetector.Process
00494b32 +021a eac3to.exe madUpStream 1114 +32 TUpStream.PassData
004a7ee1 +0319 eac3to.exe madFileStream 1400 +42 TSourceFiles.Process
0057f8f4 +00e4 eac3to.exe eac3to 3039 +6 QuickFindSourceAudioFormat
00593933 +046b eac3to.exe eac3to 5887 +83 DoItAll
005a1e56 +002e eac3to.exe eac3to 7586 +16 initialization
76eefcc7 +0017 KERNEL32.DLL BaseThreadInitThunk
thread $4668:
76eefcc7 +17 KERNEL32.DLL BaseThreadInitThunk
thread $4a74:
76eefcc7 +17 KERNEL32.DLL BaseThreadInitThunk
thread $3490:
76eefcc7 +17 KERNEL32.DLL BaseThreadInitThunk
thread $471c:
76eefcc7 +17 KERNEL32.DLL BaseThreadInitThunk
thread $31bc:
76eefcc7 +17 KERNEL32.DLL BaseThreadInitThunk
modules:
00400000 eac3to.exe 3.43.0.0 S:\EAC3TO
00b80000 libMatrix.dll S:\EAC3TO
00bb0000 hdcd.dll S:\EAC3TO
00c70000 libSsrc.dll S:\EAC3TO
10000000 libAften.dll S:\EAC3TO
66d80000 avutil-52.dll S:\EAC3TO
6a0c0000 avcodec-54.dll S:\EAC3TO
6e100000 wininet.dll 11.0.19041.3636 C:\Windows\SYSTEM32
6fea0000 dbghelp.dll 6.2.19041.3636 C:\Windows\SYSTEM32
71630000 FaultRep.dll 6.2.19041.3636 C:\Windows\SYSTEM32
716a0000 libdcadec.dll S:\EAC3TO
716f0000 libFlac.dll S:\EAC3TO
721d0000 CoreUIComponents.dll 6.2.19041.3636 C:\Windows\System32
72450000 CoreMessaging.dll 6.2.19041.3636 C:\Windows\System32
724f0000 textinputframework.dll 6.2.19041.3758 C:\Windows\SYSTEM32
72b50000 dbgcore.DLL 6.2.19041.3636 C:\Windows\SYSTEM32
73580000 wintypes.dll 6.2.19041.3636 C:\Windows\SYSTEM32
73770000 comctl32.dll 5.82.19041.3636 C:\Windows\WinSxS\x86_microsoft.windows.common-controls_6595b64144ccf1df_5.82.19041.3636_none_c0df324c38bbc0ce
73de0000 propsys.dll 7.0.19041.3636 C:\Windows\system32
73fb0000 wsock32.dll 6.2.19041.1 C:\Windows\SYSTEM32
73fc0000 kernel.appcore.dll 6.2.19041.3758 C:\Windows\SYSTEM32
74590000 Wldp.dll 6.2.19041.3636 C:\Windows\SYSTEM32
745c0000 SspiCli.dll 6.2.19041.3636 C:\Windows\SYSTEM32
745f0000 winmm.dll 6.2.19041.3636 C:\Windows\SYSTEM32
74620000 uxtheme.dll 6.2.19041.3636 C:\Windows\system32
746a0000 windows.storage.dll 6.2.19041.3758 C:\Windows\SYSTEM32
74f50000 ntmarta.dll 6.2.19041.3636 C:\Windows\SYSTEM32
74fa0000 version.dll 6.2.19041.3636 C:\Windows\SYSTEM32
750c0000 TextShaping.dll C:\Windows\SYSTEM32
75300000 comdlg32.dll 6.2.19041.3758 C:\Windows\System32
753b0000 shell32.dll 6.2.19041.3758 C:\Windows\System32
75970000 ucrtbase.dll 6.2.19041.3636 C:\Windows\System32
75c00000 combase.dll 6.2.19041.3636 C:\Windows\System32
75e80000 GDI32.dll 6.2.19041.3636 C:\Windows\System32
75eb0000 msvcp_win.dll 6.2.19041.3636 C:\Windows\System32
75f30000 IMM32.DLL 6.2.19041.3636 C:\Windows\System32
75fc0000 win32u.dll 6.2.19041.3803 C:\Windows\System32
76070000 user32.dll 6.2.19041.3803 C:\Windows\System32
76230000 clbcatq.dll 2001.12.10941.16384 C:\Windows\System32
762b0000 gdi32full.dll 6.2.19041.3803 C:\Windows\System32
763a0000 MSCTF.dll 6.2.19041.3636 C:\Windows\System32
76480000 ole32.dll 6.2.19041.3636 C:\Windows\System32
76570000 oleaut32.dll 6.2.19041.3636 C:\Windows\System32
76610000 WS2_32.dll 6.2.19041.3636 C:\Windows\System32
76680000 msvcrt.dll 7.0.19041.3636 C:\Windows\System32
76740000 sechost.dll 6.2.19041.3636 C:\Windows\System32
767c0000 advapi32.dll 6.2.19041.3693 C:\Windows\System32
76840000 bcryptPrimitives.dll 6.2.19041.3636 C:\Windows\System32
768d0000 shcore.dll 6.2.19041.3636 C:\Windows\System32
76970000 RPCRT4.dll 6.2.19041.3758 C:\Windows\System32
76ed0000 KERNEL32.DLL 6.2.19041.3636 C:\Windows\System32
77020000 CFGMGR32.dll 6.2.19041.3636 C:\Windows\System32
77160000 SHLWAPI.dll 6.2.19041.3636 C:\Windows\System32
771b0000 KERNELBASE.dll 6.2.19041.3803 C:\Windows\System32
77460000 ntdll.dll 6.2.19041.3693 C:\Windows\SYSTEM32
cpu registers:
eax = 0005064a
ebx = 0000000a
ecx = 061f8000
edx = 0000001a
esi = 00000008
edi = 00000006
eip = 00499af6
esp = 0019e5fc
ebp = 0019eb48
stack dump:
0019e5fc 00 3e df ab cf 06 05 00 - 00 80 1f 06 00 00 00 00 .>..............
0019e60c 14 ec 19 00 48 eb 19 00 - f8 7c af 2a 20 00 00 00 ....H....|.* ...
0019e61c eb 9b 49 00 38 39 53 00 - 48 eb 19 00 64 eb 19 00 ..I.89S.H...d...
0019e62c da 9c 49 00 00 00 00 00 - 30 00 00 00 8a 5e 53 00 ..I.....0....^S.
0019e63c 30 ec 19 00 d4 47 40 00 - 14 ec 19 00 38 39 53 00 0....G@.....89S.
0019e64c 13 00 00 00 a0 b6 5f 02 - 00 00 00 00 00 00 00 00 ......_.........
0019e65c 00 00 00 00 00 00 00 00 - 00 00 00 00 00 00 00 00 ................
0019e66c 00 00 00 00 00 00 00 00 - 00 00 00 00 00 00 00 00 ................
0019e67c 00 00 00 00 00 00 00 00 - 00 00 00 00 00 00 00 00 ................
0019e68c 00 00 00 00 00 00 00 00 - 00 00 00 00 00 00 00 00 ................
0019e69c 00 00 00 00 00 00 00 00 - 00 00 00 00 00 00 00 00 ................
0019e6ac 00 00 00 00 00 00 00 00 - 00 00 00 00 00 00 00 00 ................
0019e6bc 00 00 00 00 00 00 00 00 - 00 00 00 00 00 00 00 00 ................
0019e6cc 00 00 00 00 00 00 00 00 - 00 00 00 00 00 00 00 00 ................
0019e6dc 00 00 00 00 00 00 00 00 - 00 00 00 00 00 00 00 00 ................
0019e6ec 00 00 00 00 00 00 00 00 - 00 00 00 00 00 00 00 00 ................
0019e6fc 00 00 00 00 00 00 00 00 - 00 00 00 00 00 00 00 00 ................
0019e70c 00 00 00 00 00 00 00 00 - 00 00 00 00 00 00 00 00 ................
0019e71c 00 00 00 00 00 00 00 00 - 00 00 00 00 00 00 00 00 ................
0019e72c 00 00 00 00 00 00 00 00 - 00 00 00 00 00 00 00 00 ................
disassembling:
[...]
00499ae6 259 inc dword ptr [esp+$c]
00499aea jmp loc_499af2
00499aec 261 xor ecx, ecx
00499aee mov [esp+$c], ecx
00499af2 262 mov ecx, [esp+8]
00499af6 > mov [ecx], al
00499af8 263 xor eax, eax
00499afa 264 inc dword ptr [esp+8]
00499afe 265 inc dword ptr [esp+4]
00499b02 266 xor esi, esi
00499b04 238 test edx, edx
[...]
EAC3TO Bug Reports and Feature Requests Only
Thanks guys. Please re-download 3.43 test. I backed out the AUDs workaround. We're probably going to have to live with the AUDs limitation.
Curly Howard
Director of EAC3TO Development
Director of EAC3TO Development
- SomeHumanPerson
- Posts: 96
- Joined: Fri Mar 24, 2023 10:41 am
EAC3TO Bug Reports and Feature Requests Only
There are many retail Blu-rays that use 24.000 frame rate (particularly European discs), and quite a few streaming service TV offerings as well (some from Amazon are errors, but Netflix for example has many that are official/correct).
I agree that warning about 24.000/30.000 is pointless.
Not sure what eac3to does about VFR files. If you look at some VFR files in MediaInfo, you just get a very strange "average" as the "frame rate" and not always any indication of the reason (i.e. that is is VFR). If anything was going to be announced/warned to the user, I would consider that siutation much more relevant (because it has serious implications for any processing you might do on audio or video).
I agree that warning about 24.000/30.000 is pointless.
Not sure what eac3to does about VFR files. If you look at some VFR files in MediaInfo, you just get a very strange "average" as the "frame rate" and not always any indication of the reason (i.e. that is is VFR). If anything was going to be announced/warned to the user, I would consider that siutation much more relevant (because it has serious implications for any processing you might do on audio or video).
EAC3TO Bug Reports and Feature Requests Only
Fully agree with that!
Guys, I went ahead and released 3.43, mostly because 3.42 was showing false positives. Windows Defender is so fickle!
* Fixed crash with no INI file.
* Removed video framerate warnings for 24/30 fps.
* Fixed HEVC SPS parsing.
Guys, I went ahead and released 3.43, mostly because 3.42 was showing false positives. Windows Defender is so fickle!
* Fixed crash with no INI file.
* Removed video framerate warnings for 24/30 fps.
* Fixed HEVC SPS parsing.
Curly Howard
Director of EAC3TO Development
Director of EAC3TO Development
EAC3TO Bug Reports and Feature Requests Only
Yes, I have some crash not only without .ini file but with some input files, I can't know for what (maybe HEVC).
But with the latest 3.43 seems solved now.
EAC3TO Bug Reports and Feature Requests Only
Yah, the AUDs workaround was causing AVC streams to be detected as HEVC. I might be able to rescue it, we'll see.
Curly Howard
Director of EAC3TO Development
Director of EAC3TO Development
EAC3TO Bug Reports and Feature Requests Only
I too can confirm that the latest 3.43 build has fixed the issue with this particular file I was having issue with that had AVC/DTS-HD streams, as @skull had discovered HEVC/DTS-HD streams were unaffected, I failed to mention I had no issues with HEVC with the previous 3.43 test build, anyway thanks again for sorting it quickly.
EAC3TO Bug Reports and Feature Requests Only
Hi, thanks for taking over the development of eac3to.
There is an issue with 7.1 eac3 tracks (I believe only those without a 5.1 core) not recognised when muxed inside an mkv container. See log:
There is an issue with 7.1 eac3 tracks (I believe only those without a 5.1 core) not recognised when muxed inside an mkv container. See log:
Code: Select all
MKV, 1 video track, 6 audio tracks, 5 subtitle tracks, 1:57:50, 24p /1.001
1: h264/AVC, 1080p24 /1.001 (16:9)
2: TrueHD (Atmos), English, 7.1 channels, 48kHz, dialnorm: -31dB, 31ms
3: EAC3, English, 7.1 channels, 48kHz, dialnorm: 0dB
4: AC3, English, 5.1 channels, 640kbps, 48kHz, dialnorm: -31dB
5: AC3, English, 5.1 channels, 640kbps, 48kHz, dialnorm: -31dB
6: AC3, English, 2.0 channels, 320kbps, 48kHz, dialnorm: -31dB
7: AC3, English, 2.0 channels, 320kbps, 48kHz, dialnorm: -31dB
8: Subtitle (PGS), English
9: Subtitle (PGS), English
10: Subtitle (PGS), English
11: Subtitle (PGS), English
12: Subtitle (PGS), English
Bitstream parsing for track 3 failed.
Demuxing this track may still produce correct results - or not.