[LOCKED] EAC3TO Bug Reports and Feature Requests Only

eac3to forked from madshi eac3to 3.36
DAE avatar
HPotter
Posts: 42
Joined: Thu Jul 29, 2021 9:54 am

EAC3TO Bug Reports and Feature Requests Only

Post by HPotter »

Curly wrote:
Fri Jan 05, 2024 10:11 am
HPotter wrote:
Fri Jan 05, 2024 9:28 am
But, if we have some playlist less 10 min like 8 min and specify it in command line with direct path like:
eac3to "\BDMV\PLAYLIST\00006.mpls"

we will see nothing because it's not shown playlists less than 10 min, but in this case should be shown because it's direct path but not just disk playlists list.
The minDuration function makes the playlist disappear for all purposes. That will not be changed.
But if you write the concrete file with direct path I guess you think that it should be open, here nothing to do for -minDuration function because you want open exactly file that you write in path.
It's not about all playlists shown on disk - it's about open concrete file.

For usual behavior yes it should not shown, but for concrete file I think it should be open without any function, it's not job for -minDuration function in this case.
User avatar
Curly
Posts: 768
Joined: Sun Mar 15, 2020 11:05 am

EAC3TO Bug Reports and Feature Requests Only

Post by Curly »

I'll try to do what you ask. BTW, correct syntax is:

eac3to disk 3) -minDuration=0

You had them reversed.
Curly Howard
Director of EAC3TO Development
User avatar
Curly
Posts: 768
Joined: Sun Mar 15, 2020 11:05 am

EAC3TO Bug Reports and Feature Requests Only

Post by Curly »

OK, boys and girls, try eac3to_3.44_test.rar. HPotter, I hope it is working as you like, i.e., minDuration applies only when listing playlists, and you can directly input the MPLS. Happy?

Just so you know, eac3to option processing is very complex. Not so KISS as I like. That's why I try not to change it too much. But we play the hand we are dealt.
Curly Howard
Director of EAC3TO Development
User avatar
SomeHumanPerson
Posts: 96
Joined: Fri Mar 24, 2023 10:41 am

EAC3TO Bug Reports and Feature Requests Only

Post by SomeHumanPerson »

Curly wrote:
Fri Jan 05, 2024 12:40 pm
Just so you know, eac3to option processing is very complex.
That is unfortunate, and I'm glad that you mentioned it. It's very easy to ask for various options from the sidelines without realizing how much effort they might require.
User avatar
Rocky
Posts: 3754
Joined: Fri Sep 06, 2019 12:57 pm

EAC3TO Bug Reports and Feature Requests Only

Post by Rocky »

Curly needed 3.5 hours to fix HPotter's bug (and I would have too). Stuff like that in our tools is about 10 minutes. ;)

I'm not dissing, just saying. eac3to has a lot of ordering restrictions and special cases.
DAE avatar
HPotter
Posts: 42
Joined: Thu Jul 29, 2021 9:54 am

EAC3TO Bug Reports and Feature Requests Only

Post by HPotter »

Curly wrote:
Fri Jan 05, 2024 12:40 pm
OK, boys and girls, try eac3to_3.44_test.rar. HPotter, I hope it is working as you like, i.e., minDuration applies only when listing playlists, and you can directly input the MPLS. Happy?

Just so you know, eac3to option processing is very complex. Not so KISS as I like. That's why I try not to change it too much. But we play the hand we are dealt.
Seems it's working properly now, thx!
Direct path for playlist opening it fine now.
With long "-minDuration=600" in .ini and less 600 sec "-minDuration=0" or "-minDuration=100" in command line shows and open short playlists now like
eac3to disk 3) -minDuration=0 or eac3to disk -minDuration=0 3) - without error.
so promt command line now charge vs. .ini settings for -minDuration.

Thx for fast fixing. :salute:
User avatar
Curly
Posts: 768
Joined: Sun Mar 15, 2020 11:05 am

EAC3TO Bug Reports and Feature Requests Only

Post by Curly »

Thank you, Harry. I owe you a lollipop. :salute:

"eac3to disk -minDuration=0 3) - without error"

A fortuitous side effect of the changes I made. :lol:

Now we need Trunks to confirm sups are OK then we can release 3.44.

Gonna take my siesta now. Back in a couple...years! :lol:
Curly Howard
Director of EAC3TO Development
DAE avatar
Trunks
Posts: 32
Joined: Wed Nov 08, 2023 8:59 am

EAC3TO Bug Reports and Feature Requests Only

Post by Trunks »

Curly wrote:
Fri Jan 05, 2024 1:54 pm
Now we need Trunks to confirm sups are OK then we can release 3.44.
It's all good!
User avatar
Curly
Posts: 768
Joined: Sun Mar 15, 2020 11:05 am

EAC3TO Bug Reports and Feature Requests Only

Post by Curly »

You get a lollipop too.
Curly Howard
Director of EAC3TO Development
User avatar
Curly
Posts: 768
Joined: Sun Mar 15, 2020 11:05 am

EAC3TO Bug Reports and Feature Requests Only

Post by Curly »

3.44 was released. Thank you folks for your reports, debugging help, and testing. :salute:
Curly Howard
Director of EAC3TO Development
User avatar
Curly
Posts: 768
Joined: Sun Mar 15, 2020 11:05 am

EAC3TO Bug Reports and Feature Requests Only

Post by Curly »

HPotter wrote:
Fri Jan 05, 2024 9:28 am
Too bad you don't want to made some switcher that could be show playlists like in 3.36.
as a reward for ur contributions i'm gonna add back the -showall option
when ur happy i'm happy
Curly Howard
Director of EAC3TO Development
User avatar
Rocky
Posts: 3754
Joined: Fri Sep 06, 2019 12:57 pm

EAC3TO Bug Reports and Feature Requests Only

Post by Rocky »

Great work, Curly!

@skull

For eac3to going forward we will only release new versions for changes. There will be no slipstreams.
DAE avatar
HPotter
Posts: 42
Joined: Thu Jul 29, 2021 9:54 am

EAC3TO Bug Reports and Feature Requests Only

Post by HPotter »

Curly wrote:
Sat Jan 06, 2024 4:11 am
HPotter wrote:
Fri Jan 05, 2024 9:28 am
Too bad you don't want to made some switcher that could be show playlists like in 3.36.
as a reward for ur contributions i'm gonna add back the -showall option
when ur happy i'm happy
Thx :salute:
User avatar
Curly
Posts: 768
Joined: Sun Mar 15, 2020 11:05 am

EAC3TO Bug Reports and Feature Requests Only

Post by Curly »

u r welcome
i have it working for 3.45
prolly give a test build later today
Curly Howard
Director of EAC3TO Development
User avatar
Curly
Posts: 768
Joined: Sun Mar 15, 2020 11:05 am

EAC3TO Bug Reports and Feature Requests Only

Post by Curly »

i put eac3to_3.45_test.rar online if y'all wanna try it out

https://rationalqm.us/eac3to
Curly Howard
Director of EAC3TO Development
User avatar
Curly
Posts: 768
Joined: Sun Mar 15, 2020 11:05 am

EAC3TO Bug Reports and Feature Requests Only

Post by Curly »

I updated the 3.45 test build. It was deleting all options after the -showall. If -demux was at the end it was lost. That is fixed.

One thing to be clear about. If a playlist number shows up only with -showall, then you still need -showall to demux it. E.g., if we have just 1) without -showall and 1) and 2) with -showall, then "eac3to disk 2)" fails, while "eac3to disk 2) -showall" succeeds. It makes sense to me to operate that way.

I'm working on the -collapse option now.
Curly Howard
Director of EAC3TO Development
User avatar
Curly
Posts: 768
Joined: Sun Mar 15, 2020 11:05 am

EAC3TO Bug Reports and Feature Requests Only

Post by Curly »

3.45_test temporarily withdrawn to add -collapse.
Curly Howard
Director of EAC3TO Development
User avatar
Curly
Posts: 768
Joined: Sun Mar 15, 2020 11:05 am

EAC3TO Bug Reports and Feature Requests Only

Post by Curly »

OK, the 3.45_test build is back online with the -collapse option. It works as follows.

We list a disk with -showall and see this [note: we have -minDuration=600 in the INI file, otherwise we would also see a 3) which is the FBI warning]:

Code: Select all

D:\Don\Programming\Delphi\EAC3TO>eac3to G:\Rips\JFK_DIRECTORS_CUT -showall
1) 00002.mpls, 00000.m2ts+00001.m2ts+00002.m2ts, 3:25:30
   - Chapters, 13 chapters
   - h265/HEVC, 2160p24 (16:9), HDR10, BT.2020
   - h265/HEVC, 1080p24 (16:9), Dolby Vision, BT.2020
   - DTS Master Audio, English, multi-channel, 48kHz
   - DTS Master Audio, English, stereo, 48kHz
   - AC3, English, stereo, 48kHz

2) 00001.mpls, 1:34:06
   [15+15+15+15+15+15+15+15+15+15+15+15+15+15+15+15+15+15+15+15+15+15+15+15+15+15+15+15+15+15+15+15+15+15+15+15+15+15+15+15+15+15+15+15+15+15+15+15+15+15+15+15+15+15+15+15+15+15+15+15+15+15+15+15+15+15+15+15+15+15+15+15+15+15+15+15+15+15+15+15+15+15+15+15+15+15+15+15+15+15+15+15+15].m2ts
   - h265/HEVC, 2160p24 (16:9), HDR10, BT.2020
   - h265/HEVC, 1080p24 (16:9), Dolby Vision, BT.2020
   - DTS Master Audio, English, stereo, 48kHz
   - DTS Master Audio, English, stereo, 48kHz
   - DTS Master Audio, English, stereo, 48kHz
We recognize 2) as the menu. We want to demux just the first M2TS, so we give the -collapse=1 and -demux options and see this:

Code: Select all

D:\Don\Programming\Delphi\EAC3TO>eac3to G:\Rips\JFK_DIRECTORS_CUT 2) -collapse=1 -showall -demux
Running in fast mode
Keeping dialnorm
analyze: 100%
M2TS, 2 video tracks, 3 audio tracks, 1 subtitle track, 0:02:01, 24p
1: h265/HEVC, 2160p24 (16:9), 10 bits
2: h265/HEVC, 1080p24 (16:9), 10 bits
3: DTS Master Audio, English, 2.0 channels, 16 bits, 48kHz, dialnorm: 0dB
   (core: DTS, 2.0 channels, 1509kbps, 48kHz, dialnorm: 0dB)
4: DTS Master Audio, English, 2.0 channels, 16 bits, 48kHz, dialnorm: 0dB
   (core: DTS, 2.0 channels, 1509kbps, 48kHz, dialnorm: 0dB)
5: DTS Master Audio, English, 2.0 channels, 16 bits, 48kHz, dialnorm: 0dB
   (core: DTS, 2.0 channels, 1509kbps, 48kHz, dialnorm: 0dB)
6: Subtitle (PGS), English
a03 Extracting audio track number 3...
a04 Extracting audio track number 4...
a05 Extracting audio track number 5...
s06 Extracting subtitle track number 6...
v01 Extracting video track number 1...
v02 Extracting video track number 2...
v01 Creating file "00015 - 1 - h265, 2160p24.h265"...
v02 Creating file "00015 - 2 - h265, 1080p24.h265"...
a04 Creating file "00015 - 4 - DTS Master Audio, English, 2.0 channels, 16 bits, 48kHz.dtsma"...
a03 Creating file "00015 - 3 - DTS Master Audio, English, 2.0 channels, 16 bits, 48kHz.dtsma"...
a05 Creating file "00015 - 5 - DTS Master Audio, English, 2.0 channels, 16 bits, 48kHz.dtsma"...
a03 Skipping identical DTS frames (seamless branching)...
a04 Skipping identical DTS frames (seamless branching)...
a05 Skipping identical DTS frames (seamless branching)...
process: 100%
s06 Creating file "00015 - 6 - Subtitle (PGS), English.sup"...
Video track 1 contains 2890 frames.
Video track 2 contains 2890 frames.
Subtitle track 6 contains 1 caption.
eac3to processing took 3 seconds.
Done.
In summary, if you are interested in menus/warnings/etc., you'll want to know about -showall and -collapse=XXX. If you just want classic eac3to behavior then don't use -showall on the command line or in the INI file.

Now everyone can be happy. Hope it makes sense! This will probably be enough for version 3.45.

:salute: HPotter
Curly Howard
Director of EAC3TO Development
User avatar
Curly
Posts: 768
Joined: Sun Mar 15, 2020 11:05 am

EAC3TO Bug Reports and Feature Requests Only

Post by Curly »

Darn, there's still a bug, so test temporarily withdraw. I told you eac3to CL handling is complex. Standby...
Curly Howard
Director of EAC3TO Development
User avatar
Curly
Posts: 768
Joined: Sun Mar 15, 2020 11:05 am

EAC3TO Bug Reports and Feature Requests Only

Post by Curly »

OK, should be good to go now. Phew!
Curly Howard
Director of EAC3TO Development
DAE avatar
HPotter
Posts: 42
Joined: Thu Jul 29, 2021 9:54 am

EAC3TO Bug Reports and Feature Requests Only

Post by HPotter »

Curly wrote:
Sun Jan 07, 2024 4:14 am
I updated the 3.45 test build. It was deleting all options after the -showall. If -demux was at the end it was lost. That is fixed.

One thing to be clear about. If a playlist number shows up only with -showall, then you still need -showall to demux it. E.g., if we have just 1) without -showall and 1) and 2) with -showall, then "eac3to disk 2)" fails, while "eac3to disk 2) -showall" succeeds. It makes sense to me to operate that way.

I'm working on the -collapse option now.
Great!
Tried last build with -showall, -showall with -minDuration and -collapse and guess now it's working logically correct and everyone can do what they want in different combination. :salute:
User avatar
Curly
Posts: 768
Joined: Sun Mar 15, 2020 11:05 am

EAC3TO Bug Reports and Feature Requests Only

Post by Curly »

Good to hear! Thank you HPotter. And thank you for pushing me to do this. I can be stubborn. ;)

-showall is false by default, so people wanting classic behavior don't even have to know the new options exist.
Curly Howard
Director of EAC3TO Development
DAE avatar
HPotter
Posts: 42
Joined: Thu Jul 29, 2021 9:54 am

EAC3TO Bug Reports and Feature Requests Only

Post by HPotter »

Got weird thing about .sup subs.
If I doing those command for few .m2ts files, going to join them to one file and saving subs in .sup seems timings incorrect. It's going after first file timings from start 00 sec again and after every file going from start again but should be continued.

eac3to "00010.m2ts"+"00011.m2ts"+"00014.m2ts"+"00015.m2ts"+"00016.m2ts"+"00017.m2ts"+"00018.m2ts"+"00019.m2ts"+"00020.m2ts"+"00021.m2ts" 3: Subs.sup

It's the same for all version since 3.36 till 3.43-3.45 test

In 3.36 it's going fine and correct timing.
Provided you .m2ts files and .sup made by 3.36 and last version.

Video and audio joined looks fine, but not cheched a lot.
User avatar
Curly
Posts: 768
Joined: Sun Mar 15, 2020 11:05 am

EAC3TO Bug Reports and Feature Requests Only

Post by Curly »

OK, I'll look into it.
Curly Howard
Director of EAC3TO Development
User avatar
Curly
Posts: 768
Joined: Sun Mar 15, 2020 11:05 am

EAC3TO Bug Reports and Feature Requests Only

Post by Curly »

Should be fixed. Please re-download 3.45_test and give it a try. Lemme know if it's good.

That was caused by some leftovers of my first attempt to fix subs sync for seamless branching disks. When I moved on to my second and successful attempt, I forgot to toss out the leftovers. :oops:

Thanks for reporting this, HPotter! I already owe you a lollipop so this time you get a brownie.
Curly Howard
Director of EAC3TO Development
Locked