[LOCKED] EAC3TO Bug Reports and Feature Requests Only

eac3to forked from madshi eac3to 3.36
Locked
User avatar
Curly
Posts: 718
Joined: Sun Mar 15, 2020 11:05 am

EAC3TO Bug Reports and Feature Requests Only

Post by Curly »

Trunks wrote:
Fri Dec 08, 2023 9:40 am
command line: eac3to Video24.hevc Video23.hevc -24.000 -changeTo23.976
Please give a link to Video24.hevc.

Every .hevc file I tried with 3.42 test gives:

"The format of the source file could not be detected."

3.34 also gives the same error. That bears investigating in itself but for your problem I'll need your source file.
Curly Howard
Director of EAC3TO Development
User avatar
Curly
Posts: 718
Joined: Sun Mar 15, 2020 11:05 am

EAC3TO Bug Reports and Feature Requests Only

Post by Curly »

horseshowers wrote:
Sun Dec 10, 2023 6:13 am
I've found an issue: the program encodes an AC3 file when demuxing Shrek 3D, even if I just run the -check command. I can provide the files through PM if needed.
Yes, please do provide the source file.
Also, a very nice fix would be to replace the error/success wav files. I have done so locally with WinXP sounds, but occasionally forget to do so when updating. Always a shock how LOUD the default sounds are.
Feel free to also provide suggested replacement sound files.
Curly Howard
Director of EAC3TO Development
User avatar
Curly
Posts: 718
Joined: Sun Mar 15, 2020 11:05 am

EAC3TO Bug Reports and Feature Requests Only

Post by Curly »

OK boys and girls, after extensive tracing I've discovered why lots of elementary HEVC streams are not properly detected. I found two causes so far (there may be more):

1. The stream lacks access unit delimiters (AUDs). Same issue as for AVC.
2. The stream does not contain frame rate information.

Considering what to do about these. Honestly, eac3to is currently poor with elementary video streams.
Curly Howard
Director of EAC3TO Development
User avatar
Curly
Posts: 718
Joined: Sun Mar 15, 2020 11:05 am

EAC3TO Bug Reports and Feature Requests Only

Post by Curly »

Trunks wrote:
Fri Dec 08, 2023 9:40 am
eac3to Video24.hevc Video23.hevc -24.000 -changeTo23.976
Assuming you get past the two gotchas just posted, the extension on Video23 currently must be h265. I fixed it locally to accept 265 and hevc.
Curly Howard
Director of EAC3TO Development
DAE avatar
Trunks
Posts: 32
Joined: Wed Nov 08, 2023 8:59 am

EAC3TO Bug Reports and Feature Requests Only

Post by Trunks »

Indeed, seems to work fine with .h265. I was using .hevc because it was a video demuxed with DGDemux and DGDemux uses .hevc.
User avatar
Curly
Posts: 718
Joined: Sun Mar 15, 2020 11:05 am

EAC3TO Bug Reports and Feature Requests Only

Post by Curly »

sure yeah and thx for your report
my bad cuz i fixed this for avc but shudda did hevc
dont worry eac3to is gonna kick butt with elementary video
u heard it here
Curly Howard
Director of EAC3TO Development
DAE avatar
horseshowers
Posts: 20
Joined: Sun Jul 16, 2023 4:09 am

EAC3TO Bug Reports and Feature Requests Only

Post by horseshowers »

Curly wrote:
Sun Dec 10, 2023 7:47 am
Yes, please do provide the source file.
PM sent.
Feel free to also provide suggested replacement sound files.
I did not put a lot of effort into making better sounds, but I lowered the volume by about 12dB so they won't be so insanely loud anymore, see attached zip.
Attachments
eac3to_sounds.zip
(32.06 KiB) Downloaded 227 times
User avatar
Curly
Posts: 718
Joined: Sun Mar 15, 2020 11:05 am

EAC3TO Bug Reports and Feature Requests Only

Post by Curly »

thank you sir for both
downloading now
Curly Howard
Director of EAC3TO Development
User avatar
skull
Posts: 69
Joined: Thu Nov 02, 2023 7:58 pm
Location: canada

EAC3TO Bug Reports and Feature Requests Only

Post by skull »

Thanks for that horseshowers, it was indeed a tad loud before, I agree. Another option is to just automatically use the Windows system settings for the user's alert/error sounds, but not sure how much effort that is, so maybe we can stick to the unique sound files, since they've always been there. :)
User avatar
Curly
Posts: 718
Joined: Sun Mar 15, 2020 11:05 am

EAC3TO Bug Reports and Feature Requests Only

Post by Curly »

I updated the 3.42 test build with the fix to accept .hevc and .265 extensions in addition to .h265.

Gonna look at the horseshowers stuff now. But I see the sound files are flac, why not wav as currently?

My optimism on fixing the AUDs dependency for elementary AVC/HEVC was misplaced. It's looking like a nightmare. We may have to live with it, possibly improving the error message. I also thought of making a utility to AUDify a stream, but that seems goofy.
Curly Howard
Director of EAC3TO Development
User avatar
Curly
Posts: 718
Joined: Sun Mar 15, 2020 11:05 am

EAC3TO Bug Reports and Feature Requests Only

Post by Curly »

I just converted the softer flacs to wavs and put them in the uploaded 3.42 test.

Ha ha, I used eac3to to convert to WAV. :idea:
Curly Howard
Director of EAC3TO Development
DAE avatar
horseshowers
Posts: 20
Joined: Sun Jul 16, 2023 4:09 am

EAC3TO Bug Reports and Feature Requests Only

Post by horseshowers »

skull wrote:
Sun Dec 10, 2023 7:53 pm
Another option is to just automatically use the Windows system settings for the user's alert/error sounds, but not sure how much effort that is, so maybe we can stick to the unique sound files, since they've always been there. :)
The major benefit of the current system is that they're very easy to replace, so users can use whichever sounds we want. I vote to keep it.
Curly wrote:
Mon Dec 11, 2023 5:49 am
Gonna look at the horseshowers stuff now. But I see the sound files are flac, why not wav as currently?
I was lazy and adjusted the volume using a DSP filter during FLAC conversion with dBpoweramp, simple as.
User avatar
Curly
Posts: 718
Joined: Sun Mar 15, 2020 11:05 am

EAC3TO Bug Reports and Feature Requests Only

Post by Curly »

I was able to reproduce the re-encoding with this command:

eac3to d:\rips\shrek_3d 3) -check

But this does not re-encode:

eac3to d:\rips\shrek_3d 3) -demux

horseshowers, you said it happens when demuxing. Can you confirm that and show the command line and trace.

Dunno, maybe -check is supposed to do that. Investigating...
Curly Howard
Director of EAC3TO Development
DAE avatar
horseshowers
Posts: 20
Joined: Sun Jul 16, 2023 4:09 am

EAC3TO Bug Reports and Feature Requests Only

Post by horseshowers »

Curly wrote:
Mon Dec 11, 2023 7:09 am
horseshowers, you said it happens when demuxing. Can you confirm that and show the command line and trace.

Dunno, maybe -check is supposed to do that. Investigating...
I have to admit I never actually tested -demux, just assumed it would happen there as well. It's very rare to see -check encoding, it usually just reads the track. I have seen it before and I think that was related to seamless branching with TrueHD, the last time it was fixed by downgrading to v3.35 but that didn't help with this disc. I ran -check on 3.35, 3.36, and 3.42, all encoded.
User avatar
Curly
Posts: 718
Joined: Sun Mar 15, 2020 11:05 am

EAC3TO Bug Reports and Feature Requests Only

Post by Curly »

Gotcha thanks. I'm going to check with madshi to be sure but I think with -check it wants to make sure decoding and encoding will be successful if a future invocation should require it.
Curly Howard
Director of EAC3TO Development
User avatar
Curly
Posts: 718
Joined: Sun Mar 15, 2020 11:05 am

EAC3TO Bug Reports and Feature Requests Only

Post by Curly »

madshi says it's a bug so I'll have to investigate. It's not a giant problem though.
Curly Howard
Director of EAC3TO Development
User avatar
Curly
Posts: 718
Joined: Sun Mar 15, 2020 11:05 am

EAC3TO Bug Reports and Feature Requests Only

Post by Curly »

Strictly speaking, it's not a bug. But the behavior is definally not what we want.

Guys, re-download 3.42 test to get the fix for not re-encoding with -check. The problem was that eac3to with -check was queuing up an action for %check%.thd+ac3 (remember, we changed that a while back for -demux). Well, we know that using an extension of thd+ac3 causes re-encoding (and that's why all previous versions re-encoded), so I fixed that to just queue up %check%.thd. Seems to work fine.

https://rationalqm.us/eac3to

OK, we made Trunks and horseshowers happy. Maybe now I will work on the man page.
Curly Howard
Director of EAC3TO Development
User avatar
Curly
Posts: 718
Joined: Sun Mar 15, 2020 11:05 am

EAC3TO Bug Reports and Feature Requests Only

Post by Curly »

I updated the changelog in the 3.42 test build online. I think we'll go ahead and release this.
Curly Howard
Director of EAC3TO Development
User avatar
Curly
Posts: 718
Joined: Sun Mar 15, 2020 11:05 am

EAC3TO Bug Reports and Feature Requests Only

Post by Curly »

The 3.42 release candidate is online. Please give it a whirl and if nothing is found, I'll make a release notification.

https://rationalqm.us/eac3to
Curly Howard
Director of EAC3TO Development
User avatar
skull
Posts: 69
Joined: Thu Nov 02, 2023 7:58 pm
Location: canada

EAC3TO Bug Reports and Feature Requests Only

Post by skull »

Great work, as always! Btw, videohelp already pushed this update to the eac3to page, without being prompted. So far, so good, in my testing of this build. I also sent a friendly suggestion to maybe update the developer's website link from doom9 thread to this forum too (which they have now actioned!).
User avatar
Curly
Posts: 718
Joined: Sun Mar 15, 2020 11:05 am

EAC3TO Bug Reports and Feature Requests Only

Post by Curly »

Great, thank you, skull.

I guess it's not a candidate anymore. ;)
Curly Howard
Director of EAC3TO Development
User avatar
skull
Posts: 69
Joined: Thu Nov 02, 2023 7:58 pm
Location: canada

EAC3TO Bug Reports and Feature Requests Only

Post by skull »

Haha, yeah. For future, I believe their staff now monitor https://rationalqm.us/eac3to and unless you put "beta" in the archive filename, they will probably assume it's official and upload as such. ;)
User avatar
Curly
Posts: 718
Joined: Sun Mar 15, 2020 11:05 am

EAC3TO Bug Reports and Feature Requests Only

Post by Curly »

OK, good idea for the next version.

He he, I just saw over on doom9 somebody asking how to make eac3to keep all the chapters. 8-) I promise, I didn't pay them.
Curly Howard
Director of EAC3TO Development
User avatar
skull
Posts: 69
Joined: Thu Nov 02, 2023 7:58 pm
Location: canada

EAC3TO Bug Reports and Feature Requests Only

Post by skull »

Haha, that was beautiful timing indeed. I alerted that fine individual that our newest version has exactly what they want. ;)
User avatar
Curly
Posts: 718
Joined: Sun Mar 15, 2020 11:05 am

EAC3TO Bug Reports and Feature Requests Only

Post by Curly »

dont speak 2 soon
some loser, oops i ment user, over there is rebelling
i wudnt bother replying skull
just let it go
but if u wanna joust with the guy go for it cud be amussing
nobody applied for WW's $$$ reward i wonder why
Curly Howard
Director of EAC3TO Development
Locked