Support forum for DG Tools

OK, guys, what should I work on? We don't have any open bugs/issues. I was thinking to work on Guest 2's language preferences stuff. But tell me what y'all want. Think big!

gonca wrote: ↑

Wed Mar 10, 2021 3:38 pm

new_guy, please get a face

Hope you like my new avatar better.

OK, I'm going to work on autocropping improvements and language preferences.

new_guy wrote: ↑

Fri Mar 12, 2021 10:41 am

gonca wrote: ↑

Wed Mar 10, 2021 3:38 pm

new_guy, please get a face

Hope you like my new avatar better.

Getting there

Rocky wrote: ↑

Fri Mar 12, 2021 12:04 pm

OK, I'm going to work on autocropping improvements and language preferences.

autocrop for the entire stream (using samples) would be awesome
This would be great for movies that use different cameras/resolutions

Please explain more. Thank you.

Also it was Guest 2 IIRC that asked for the main window navigation to remain enabled when the crop window is on display. That way you can sample around to see if the selected cropping is good everywhere. Or we could run a pass over the entire stream finding the cropping that catches all the blackness. Is that what you were thinking of, gonca?

I believe one such movie is The Dark Knight Rises.
Some of the movie is shot in a 2.40:1 aspect ratio while other parts are shot in 1.78:1
Different ratios in the same movie.
Would be good if autocropping could scan the video to find the "correct aspect ratio"
In this case 1.78:1 since that fills the screen

You are right, we can do it manually but if we had an automated way it would be easier

Please give link to purchase that disk. Thank you.

gonca wrote: ↑

Fri Mar 12, 2021 7:56 pm

I believe one such movie is The Dark Knight Rises.
Some of the movie is shot in a 2.40:1 aspect ratio while other parts are shot in 1.78:1
Different ratios in the same movie.

Can you please explain how you know that and how you identify the different parts?

I manually scan the entire timeline (dragging the navigation slider) and look for different ratios.
You can see the top and bottom black bars appear and disappear.
It isn't that hard to do, so this is one of those "would be nice" items
Guest 2's language selection would also be useful

Thank you.

@gonca

OK, the movie has parts that require no cropping (no black bars) and parts that require cropping (has top and bottom black bars). What are you expecting an automated cropping function to do with that? Leave everything uncropped or crop everything? Just report on matters?

With auto cropping I would expect it to have zero cropping on the height in this case
Example
Movie has aspect ratios of 3840 x 1600, 3840 x 1800, and 3840 x 1700
Auto cropping would report a cropping value for 3840 x 1800, the largest picture area with actual data, excluding black bars for padding

OK, thank you. Makes sense. I'll have to scan the entire stream to find the maximum cropping that does not crop real content.

Gonna have an Analyze button that runs a scan of the whole stream skipping by GOP. At each GOP start frame the cropping will be calculated and then at the end the smallest crop will be set as you described.

Sounds good.

Gonna need to have Analyze mod4, mod8, and mod 32 buttons, unless you can think of a better UI. And hopefully going by GOP won't miss anything.

I already have the cropping dialog non-modal in my local build. Sensitivity has been increased to 40, which better clobbers near-blacks.

Going by GOP shouldn't miss anything

Rocky wrote: ↑

Tue Mar 16, 2021 9:23 pm

unless you can think of a better UI. And hopefully going by GOP won't miss anything.

IMHO there is no need for 3 different analysises.

Once DGIndexNV becomes aware of the wider/higher resolution, it can crop to that one, applying the desired MOD.

In future it could output different DGI/AVS for every different resolution part. The need for this is that, apart from IMAX movies, some restored ones have different resolution for the recovered parts, that need different filter treatment. Having the trimmed parts would be way easier for us to work on them.

Rocky wrote: ↑

Tue Mar 16, 2021 9:23 pm

I already have the cropping dialog non-modal in my local build. Sensitivity has been increased to 40, which better clobbers near-blacks.

Why don't you expose that parameter?

Guest 2 wrote: ↑

Thu Mar 18, 2021 5:08 am

Once DGIndexNV becomes aware of the wider/higher resolution, it can crop to that one, applying the desired MOD.

I don't get it. How would the desired mod be known?

Why don't you expose that parameter?

Because then autocrop would not be automatic.

Rocky wrote: ↑

Thu Mar 18, 2021 9:55 am

How would the desired mod be known?

Hi Rocky! Bit of time I haven't written you

Perhaps I have wrongly understood and I have pictured you want to run a separate analysis for every mod. Am I wrong?

Rocky wrote: ↑

Thu Mar 18, 2021 9:55 am

Because then autocrop would not be automatic.

I meant, a sensitivity slider in the options.

We have now an autocrop button for each mod that works on the current frame. What buttons would you add and how would they work to support scanning the entire stream and autocropping accordingly?

If the user has to determine sensitivity per source using a slider then the process is not automatic. In any case, I do not see the need for making it configurable.

Rocky wrote: ↑

Thu Mar 18, 2021 11:25 am

We have now an autocrop button for each mod that works on the current frame. What buttons would you add and how would they work to support scanning the entire stream and autocropping accordingly?

I would add one more button only for scanning. Useless to scan multiple times just to have the preview of each crop mod.

C'mon, think it through and answer thoroughly. I have to write actual code. What will be the result of a scan and what will you do with it and when? Can't do a scan and then select one of the existing autocrop buttons, because they are implemented to autocrop the current frame.